MYSQL_SECURE_AUTH has been removed in MySQL 8.0.3 RC #892
Conversation
https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-3.html#mysqld-8-0-3-capi > The deprecated secure_auth system variable and --secure-auth client option have been removed. > The MYSQL_SECURE_AUTH option for the mysql_options() C API function was removed.
|
There are 3 failures reported with this pull request. One of them is explained in #893 |
ext/mysql2/client.c
Outdated
| rb_define_private_method(cMysql2Client, "secure_auth=", set_secure_auth, 1); | ||
| #endif |
There was a problem hiding this comment.
For consistency with several other cases, let's allow this to fail silently by leaving the method in place, but turning it into a no-op.
There was a problem hiding this comment.
Removed ifdef here. set_secure_auth method already handles if MYSQL_SECURE_AUTH is defined or not, here we do not need to handle it again. please give additional comment If I do not understand your review comment correctly.
ext/mysql2/client.c
Outdated
| @@ -1311,9 +1313,11 @@ static VALUE set_ssl_options(VALUE self, VALUE key, VALUE cert, VALUE ca, VALUE | |||
| return self; | |||
| } | |||
|
|
|||
| #if defined(MYSQL_SECURE_AUTH) | |||
There was a problem hiding this comment.
Make this method a no-op by putting the #ifdef inside the method definition. Please add a comment, something like:
/* This option was deprecated in MySQL 5.x and removed in MySQL 8.0 */
There was a problem hiding this comment.
Thanks for the review. Changed ifdef location inside the method.
and add comments when this option was removed
`MYSQL_SECURE_AUTH` inside.
https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-3.html#mysqld-8-0-3-capi The deprecated secure_auth system variable and --secure-auth client option have been removed. The MYSQL_SECURE_AUTH option for the mysql_options() C API function was removed. This pull request addresses brianmario#891
https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-3.html#mysqld-8-0-3-capi > The deprecated secure_auth system variable and --secure-auth client option have been removed. > The MYSQL_SECURE_AUTH option for the mysql_options() C API function was removed.
…lient-support * makandra/0.3.x-lts: Use a typedef my_bool to improve compatibility across MySQL versions MYSQL_SECURE_AUTH has been removed in MySQL 8.0.3 RC (brianmario#892) Only do version check in Windows environment Fix for MariaDB 10.2 which does not define CLIENT_LONG_PASSWORD
https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-3.html#mysqld-8-0-3-capi > The deprecated secure_auth system variable and --secure-auth client option have been removed. > The MYSQL_SECURE_AUTH option for the mysql_options() C API function was removed.
https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-3.html#mysqld-8-0-3-capi
This pull request addresses #891