Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SrLatnMeTest.php #2735

Merged
merged 1 commit into from
Jan 1, 2023

Conversation

perisicnikola37
Copy link
Contributor

No description provided.

@kylekatarnls
Copy link
Collaborator

Hello, thanks for your contribution, I debugged this and saw that Symfony doesn't pick the correct "sr" pluralization because of the "Latn" or "Cyrl" variant in the locale name.

When I fix it, I see it matches your change but it also modify some other output lines, can you confirm those 4 changes are also correct:
66b9317#diff-0a9e11e82065a345aa701dbc73fdbda5c3202d13454331cb5d0392788f2adbf0

For instance 1 nedjelja 6 dan would become 1 nedjelja 6 dana:

        // Carbon::now()->addWeek()->addDays(6)->diffForHumans(null, true, false, 2)
        // '1 week 6 days'
        '1 nedjelja 6 dana',

@kylekatarnls kylekatarnls merged commit 13ee177 into briannesbitt:master Jan 1, 2023
@kylekatarnls
Copy link
Collaborator

Merged in #2740

@kylekatarnls kylekatarnls added this to the 2.65.0 milestone Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants