Revert the change for scripts/styles #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever we append a script tag using JS the script is loading ASYNC and most probably will break the order of execution
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
build/media_source/plg_editors_tinymce/js/plugins/highlighter/source.es5.js
Show resolved
Hide resolved
build/media_source/plg_editors_tinymce/js/plugins/highlighter/source.es5.js
Outdated
Show resolved
Hide resolved
build/media_source/plg_editors_tinymce/js/plugins/highlighter/source.es5.js
Outdated
Show resolved
Hide resolved
dgrammatiko
force-pushed
the
4.1-dev-tmEdit1
branch
from
aa9d6ea to
2a10148
Compare
brianteeman
added a commit
that referenced
this pull request
Nov 25, 2021
* basics * language and options * clean temp * code corrections from @Fedik * Update tinymce.php * Update tinymce.php * Build step for building the source.html (#130) * build step * Update tinymce.es6.js * Update setoptions.xml * Revert the change for scripts/styles (#131) * Revert the change for scripts/styles Whenever we append a script tag using JS the script is loading ASYNC and most probably will break the order of execution * Give the dog a bone Co-authored-by: Dimitris Grammatikogiannis <[email protected]> Co-authored-by: Benjamin Trenkle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever we append a script tag using JS the script is loading ASYNC and most probably will break the order of execution
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Expected result
Actual result
Documentation Changes Required