Jooa11y/enhancements #132
Jooa11y/enhancements #132
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| // Instantiate | ||
| const checker = new Jooa11y.Jooa11y(Jooa11yLangEn.options); | ||
| checker.doInitialCheck(); | ||
| }); |
There was a problem hiding this comment.
Newline required at end of file but not found eol-last
|
|
||
| // Instantiate | ||
| const checker = new Jooa11y.Jooa11y(Jooa11yLangEn.options); | ||
| checker.doInitialCheck(); |
There was a problem hiding this comment.
Expected indentation of 2 spaces but found 4 indent
| Jooa11y.Lang.addI18n(Jooa11yLangEn.strings); | ||
|
|
||
| // Instantiate | ||
| const checker = new Jooa11y.Jooa11y(Jooa11yLangEn.options); |
There was a problem hiding this comment.
'Jooa11y' is not defined no-undef
'Jooa11yLangEn' is not defined no-undef
Expected indentation of 2 spaces but found 4 indent
| // Set translations | ||
| Jooa11y.Lang.addI18n(Jooa11yLangEn.strings); | ||
|
|
||
| // Instantiate |
There was a problem hiding this comment.
Expected indentation of 2 spaces but found 4 indent
| } | ||
|
|
||
| // Set translations | ||
| Jooa11y.Lang.addI18n(Jooa11yLangEn.strings); |
There was a problem hiding this comment.
'Jooa11y' is not defined no-undef
'Jooa11yLangEn' is not defined no-undef
Expected indentation of 2 spaces but found 4 indent
| return; | ||
| } | ||
|
|
||
| // Set translations |
There was a problem hiding this comment.
Expected indentation of 2 spaces but found 4 indent
| // Check if Jooa11y is loaded | ||
| if (!Jooa11y) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Expected indentation of 2 spaces but found 1 tab indent
Unexpected tab character no-tabs
| window.addEventListener('load', () => { | ||
| // Check if Jooa11y is loaded | ||
| if (!Jooa11y) { | ||
| return; |
There was a problem hiding this comment.
Expected indentation of 4 spaces but found 2 tabs indent
Unexpected tab character no-tabs
| @@ -0,0 +1,13 @@ | |||
| window.addEventListener('load', () => { | |||
| // Check if Jooa11y is loaded | |||
| if (!Jooa11y) { | |||
There was a problem hiding this comment.
'Jooa11y' is not defined no-undef
Expected indentation of 2 spaces but found 1 tab indent
Unexpected tab character no-tabs
| @@ -0,0 +1,13 @@ | |||
| window.addEventListener('load', () => { | |||
| // Check if Jooa11y is loaded | |||
There was a problem hiding this comment.
Expected indentation of 2 spaces but found 1 tab indent
Unexpected tab character no-tabs
* jooa11y scaffolding
media folder
web assets
hard coded until we decide on npm or not
to install check out this branch
npm run build:js
npm run build:css
discover install the plugin
todo - aka brian needs help
[] make the checker start
[] make the checker use the settings from the plugin
* script loads now
* tippy - temp
* editor button
* toolbar
* enpugh
* Jooa11y/enhancements (#132)
* Add some enhancements
* Fix wrong name
Co-authored-by: Benjamin Trenkle <[email protected]>
* tabs
* tippy popper licence and naming
* postgresql install
* xml bug
* cleaning
* tidy
* fix
* dont need scss
* needs to be an integer
* deploy version
* might not be the best way?
* Revert "Auxiliary commit to revert individual files from 18199dd"
This reverts commit 4eb15800ccc4bb0d64580013b58a92505bc5abfc.
* clarify show
* options
* package.lock
* remove editor button
* cs
* string
* set input
* deploy
* Temporary add git to node ci (#133)
* github link
* param
* Revert "param"
This reverts commit 378a64e.
* params
* spelling
* revert
* sql field
* cs and spelling
* Fix npm
* Revert drone.yml change
* Switch package to tarball
* Use the es module
* Update eslint-plugin-vue to 8.2.0
* CS (#135)
* lang
* progress update
* fix strings
* load strings
* js change from @Fedik
* typo and package-lock
* sef and non-sef
* revert change by Dimitris
* Update joomla-a11y-checker version
* Update joomla-a11y-checker version
* Update view preview url
* simplify
* Update jooa11y.php
* fix jscs (#136)
* undo eslint change
* remove "Additional ruleset toggles" from the plugin settings
* Update .eslintrc
lets try this again
* final try
* sha
Co-authored-by: Benjamin Trenkle <[email protected]>
Co-authored-by: Harald Leithner <[email protected]>
Co-authored-by: dgrammatiko <[email protected]>
Co-authored-by: Dimitris Grammatikogiannis <[email protected]>
Co-authored-by: Benjamin Trenkle <[email protected]>
Co-authored-by: Fedir Zinchuk <[email protected]>
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Expected result
Actual result
Documentation Changes Required