fix for existing users logging from frontend

[alikon]

Pull Request for Issue # .
joomla#20051 (comment)

Testing Instructions

for existing users
when logging with an existing user you are redirected to the edit profile
when you click on I agree on the privacy field
now the profile submission is saved

[sandewt]

I have tried this: see comment joomla#20051.

The trailing is not correct.

Sorry this is not the correct way to show the code.

public function onContentPrepareForm($form, $data)
	{
		if (!($form instanceof JForm))
		{
			$this->_subject->setError('JERROR_NOT_A_FORM');

			return false;
		}

		// Check we are manipulating a valid form - we do not display this in the admin users form or profile view.
		$name   = $form->getName();
		$layout = $this->app->input->get('layout', 'default');
		$view   = $this->app->input->get('view', 'default');

		if (!in_array($name, array('com_admin.profile', 'com_users.profile', 'com_users.registration')) || $layout != "edit" && $view != "registration")
		{
			return true;
		}

		// Add the registration fields to the form.
		JForm::addFormPath(__DIR__ . '/privacyconsent');
		$form->loadFile('privacyconsent');

		$fields = array(
			'privacy',
		);

		if (is_object($data))
		{
			$userId = isset($data->id) ? $data->id : 0;

			if ($userId > 0)
			{
				// Load the profile data from the database.
				$db = JFactory::getDbo();

				$query = $db->getQuery(true)
					->select($db->quoteName('profile_value'))
					->from($db->quoteName('#__user_profiles'))
					->where($db->quoteName('user_id') . ' = ' . (int) $userId)
					->where($db->quoteName('profile_key') . ' LIKE ' . $db->quote('consent'))
					->order($db->quoteName('ordering') . ' ASC');
				$db->setQuery($query);

				try
				{
					$results = $db->loadRowList();
				}
				catch (RuntimeException $e)
				{
					$this->_subject->setError($e->getMessage());

					return false;
				}

				if (!empty($results[0]) == 1)
				{
					$form->removeField('privacy', 'privacyconsent');

					return true;
				}
			}
		}

		$privacyarticle = $this->params->get('privacy_article');
		$privacynote    = $this->params->get('privacy_note');

		// Push the privacy article ID into the privacy field.
		$form->setFieldAttribute('privacy', 'article', $privacyarticle, 'privacyconsent');
		$form->setFieldAttribute('privacy', 'note', $privacynote, 'privacyconsent');
	}

[alikon]

@sandewt doesn't matter
added to this pr
thanks

[Quy]

Remove blank line

[alikon]

done

[sandewt]

Thanks @alikon and @Quy .

Line 117:

if (!empty($results[0]) == 1)

Should be (better)

if (!empty($results[0]))

[alikon]

@sandewt changed the query a little bit

[sandewt]

@alikon / @brianteeman

At first this seemed to be a solution, but the problem is only being moved. Sad.

But when you (re) save (Edit Your Profile) the $form variable is emptied, after which the known warning message appears.

[sandewt]

better check

Thanks @alikon , works fine.

Rule 148: $option is not used anymore.

$option = $this->app->input->getCmd('option');

(The tooltip does not display the text correctly. )

[brianteeman]

I have merged this code. my feeling was that it is not correct to only show the privacyconsent field on the edit profile field when the user has previously consented and that they should consent each time they update their information. However I am not that bothered about that so I have left it with your code

THANKS!!!

[alikon]

thanks for your patience

we can always make a new pr after the things become running in the wild