Use createDocumentFragment
to append options to DOM
#586
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've bumped into a performance issue using slim-select when lots of options are repeatedly added/removed from the DOM as part of
renderOptions
.We use the
search
event to query an endpoint that returns >7,000 records. This causes each option to be individually added/removed from the DOM, this can cause slowness for our application if a user searches multiple times.With this change, instead of adding each option to the DOM one-by-one and performing lots of modifications. We create a document fragment and append to that, once all options have been processed we append the document fragment to the DOM.
I'm working on benchmarking this to support the change but, anecdotally, I am seeing an improvement in responsiveness using this change locally.
Let me know if you have any concerns with this change 👍