Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): Skip tsconfig in terraform plan #6941

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

OfekShimko
Copy link
Contributor

@OfekShimko OfekShimko commented Jan 8, 2025

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Below is a concise technical summary of the changes proposed in this PR:

Modifies the plan_utils.py file to exclude tsconfig.json from being processed as a Terraform plan file.

TopicDetails
Terraform Plan Filter Adds a condition to skip processing of tsconfig.json files in Terraform plan parsing
Modified files (1)
  • checkov/terraform/plan_utils.py
Latest Contributors(2)
UserCommitDate
maxamelfeat-terraform_plan-ad...September 04, 2024
gruebelchore-finish-up-type-h...September 17, 2023
This pull request is reviewed by Baz. Join @OfekShimko and the rest of your team on (Baz).

@OfekShimko OfekShimko merged commit e757812 into main Jan 8, 2025
34 of 35 checks passed
@OfekShimko OfekShimko deleted the skip_tsconfig_in_terraform_plan branch January 8, 2025 12:49
@pazbechor pazbechor self-requested a review January 8, 2025 12:50
Saarett pushed a commit that referenced this pull request Jan 8, 2025
skip tsconfig in terraform plan

Co-authored-by: oshimko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants