Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Gateway without WAF block. #46

Merged
merged 1 commit into from
May 2, 2021

Conversation

harkirat22
Copy link
Contributor

As per the Azure Best Practices. Found that Checkov scan didn't find this misconfiguration

@schosterbarak
Copy link
Contributor

Thanks @harkirat22 . would you like to contribute that piece to checkov?

@harkirat22
Copy link
Contributor Author

harkirat22 commented Oct 19, 2020 via email

@schosterbarak
Copy link
Contributor

@harkirat22 very cool.
We've done a short guide on it: https://www.checkov.io/5.Contribution/New-Check.html
Also, you are invited to join http://slack.bridgecrew.io/ and talk with @metahertz or myself if you want to ask a question along the way.

@harkirat22
Copy link
Contributor Author

Thank you @schosterbarak for the invite. I'll read the guide and do the contribution. Moreover, there are a couple of more checks that I have documented in my notes and they need to be in checkov.

@schosterbarak
Copy link
Contributor

@harkirat22 please do. feel free to reach out :)

@metahertz
Copy link

Echoing @schosterbarak, Thanks for raising this and feel free to reach out to either of us with any issues or questions working with the Checkov codebase! Copying existing similar checks and matching tests are a great starting point after https://www.checkov.io/5.Contribution/New-Check.html :)

@nimrodkor nimrodkor merged commit 0526802 into bridgecrewio:master May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants