Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yoncicd #55

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions terraform/aws/db-app.tf
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
resource "aws_db_instance" "default" {
name = var.dbname
engine = "mysql"
engine = "mysql"
option_group_name = aws_db_option_group.default.name
parameter_group_name = aws_db_parameter_group.default.name
db_subnet_group_name = aws_db_subnet_group.default.name
Expand Down Expand Up @@ -35,7 +35,7 @@ resource "aws_db_option_group" "default" {
engine_name = "mysql"
name = "og-${local.resource_prefix.value}"
major_engine_version = "8.0"
option_group_description = "Terraform OG"
option_group_description = "Terraform OG"

tags = {
Name = "${local.resource_prefix.value}-og"
Expand Down
13 changes: 13 additions & 0 deletions terraform/aws/s3.tf
Original file line number Diff line number Diff line change
Expand Up @@ -86,3 +86,16 @@ resource "aws_s3_bucket" "logs" {
Environment = local.resource_prefix.value
}
}

resource "aws_s3_bucket" "yonyon" {
# bucket is public
# bucket is not encrypted
# bucket does not have access logs
# bucket does not have versioning
bucket = "${local.resource_prefix.value}-data"
acl = "public-read"
force_destroy = true
tags = {
Name = "${local.resource_prefix.value}-data"
Environment = local.resource_prefix.value
}