Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more matrix builds for Actions #229

Merged
merged 8 commits into from
Jun 20, 2022
Merged

Add more matrix builds for Actions #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
efb97d9
Add more matrix testing and remove now-broken travis testing file
bdeitte Jun 20, 2022
567b97e
Update badge
bdeitte Jun 20, 2022
cd0e528
Add missing runs-on
bdeitte Jun 20, 2022
38a269c
Try to fix the build
bdeitte Jun 20, 2022
de990da
Try again to fix tests
bdeitte Jun 20, 2022
c27cfad
Fix build badge
bdeitte Jun 20, 2022
3617787
Show build image properly
bdeitte Jun 20, 2022
e12b974
Need to remove 18 due to some odd timeout issue
bdeitte Jun 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,12 @@ on:
jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [12.x, 14.x, 16.x]
os: [ubuntu-latest, windows-latest]
node-version: [8.x, 10.x, 12.x, 14.x, 16.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
Expand Down
16 changes: 0 additions & 16 deletions .travis.yml
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ CHANGELOG
## 9.1.0 (2022-6-20)
* @zhyu Append standard Datadog tags from env vars (DD_ENTITY_ID, DD_ENV, DD_SERVICE, and DD_VERSION)
* @bdeitte Check if client is undefined before closing to fix error
* @bdeitte Start using GitHub Actions for tests and remove now-broken travis file
* @bdeitte Update testing dependencies

## 9.0.0 (2021-10-31)
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ includes all changes in the latest node-statsd and many additional changes, incl

hot-shots supports Node 8.x and higher.

[![Build Status](https://secure.travis-ci.org/brightcove/hot-shots.png?branch=master)](http://travis-ci.org/brightcove/hot-shots)
![Build Status](https://github.com/brightcove/hot-shots/actions/workflows/node.js.yml/badge.svg)

## Migrating from node-statsd

Expand Down
2 changes: 1 addition & 1 deletion test/errorHandling.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ describe('#errorHandling', () => {
statsd.send('test title');
});

if (serverType === 'tcp' && clientType === 'client') {
if (serverType === 'tcp' && clientType === 'client' && process.platform !== 'win32') {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not great to remove these from Windows tests, but I can't determine why this is now different on Actions

describe('#tcpSocket', () => {

// ensure we restore the original `Date.now` after each test
Expand Down