Fix/keep model keys on release #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fotiDim
reviewed
Nov 27, 2021
lib/models/connection_status.dart
Outdated
| @@ -12,7 +12,7 @@ class ConnectionStatus { | |||
| }); | |||
|
|
|||
| @JsonKey(name: 'connected') | |||
| final bool connected; | |||
| final bool? connected; | |||
There was a problem hiding this comment.
How about we just initialize it with false? Nullability seems a bit overkill here.
There was a problem hiding this comment.
made it not nullable and therefore defaulting to false
fotiDim
reviewed
Nov 27, 2021
example/lib/main.dart
Outdated
| @@ -47,7 +57,7 @@ class _HomeState extends State<Home> { | |||
| _connected = false; | |||
| var data = snapshot.data; | |||
| if (data != null) { | |||
| _connected = data.connected; | |||
| _connected = data.connected ?? false; | |||
brim-borium
force-pushed
the
fix/keep_model_keys_on_release
branch
from
623239d to
feb52a5
Compare
fotiDim
approved these changes
Nov 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.