Small updates to the TypeScript types #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This already is the case and works, just updates the types to reflect that reality.
nvie
changed the title
childrenAccessor function to return null
|
Looks like the tsc script failed due to the readonly addition. If you remove that, I think the other change is good for this PR. |
|
Hey @jameskerr! Thanks for the feedback, I just noticed the tests were not passing, so I made a few more internal annotations to fix those. I now tested these locally by running the build script, and they now pass the The benefit of expressing that the In my use case, I found myself writing |
nvie
added a commit
to liveblocks/liveblocks
that referenced
this pull request
Nov 16, 2022
This allows us to remove a few type casts that were unnecessary, but we'll have to put in a couple more, because React Arborist needs to update their types. See brimdata/react-arborist#65
|
Great! That makes sense to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't change anything about the implementation. It just changes the types to match the current reality a little bit more strictly.