Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vector: Fix union nulls #5555

Merged
merged 2 commits into from
Jan 6, 2025
Merged

vector: Fix union nulls #5555

merged 2 commits into from
Jan 6, 2025

Conversation

mattnibs
Copy link
Collaborator

@mattnibs mattnibs commented Jan 6, 2025

This commit fixes nulls in vector Unions by added a const null vector of union type into the Union dynamic.

This commit fixes nulls in vector Unions by added a const null vector of
union type into the Union dynamic.
@mattnibs mattnibs requested a review from a team January 6, 2025 19:37
Copy link
Member

@nwt nwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

vector/union.go Outdated Show resolved Hide resolved
Co-authored-by: Noah Treuhaft <[email protected]>
@mattnibs mattnibs merged commit dd555cf into main Jan 6, 2025
3 checks passed
@mattnibs mattnibs deleted the vector-union-nulls branch January 6, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants