Add flexible inputs to Actions Workflow for running e2e tests #2961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrz
commented
Jan 11, 2024
| jobs: | ||
| run-e2e-tests: | ||
| name: Run e2e tests | ||
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| matrix: | ||
| os: [ubuntu-20.04] | ||
| os: ${{ fromJSON(inputs.platforms) }} |
There was a problem hiding this comment.
I learned this trick from actions/toolkit#184 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm hoping to invest some time to better understand and hopefully fix some of the problems we have with e2e test reliability in GitHub Actions CI. As a step toward that, in this PR I've added some flexible Inputs to the "Run e2e tests" Workflow. After this change, if the Workflow is invoked with all inputs at their defaults, it'll still run the e2e tests the same way they are in the "Advance Zed" workflow. But those inputs can now be varied to run any command line (e.g.,
yarn e2e...) on any set of OS platforms, which makes it easier to repro specific problems and confirm fixes.For instance, in this run I ran only the
copy-pastetests and did it across all OSes.