Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Viewer code and addition of volume selector #80

Merged
merged 11 commits into from
Mar 17, 2021
Merged

Refactor Viewer code and addition of volume selector #80

merged 11 commits into from
Mar 17, 2021

Conversation

brisvag
Copy link
Owner

@brisvag brisvag commented Mar 16, 2021

Volume selector is here!

Now p.show() will also automatically dock a simple dropdown menu widget in the napari viewer. This widget lets you select which volume to show!

There's also a couple of minor bufixes thrown in.

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #80 (856f255) into develop (8a149f4) will increase coverage by 2.35%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #80      +/-   ##
===========================================
+ Coverage    79.84%   82.19%   +2.35%     
===========================================
  Files           98      103       +5     
  Lines         1945     2011      +66     
===========================================
+ Hits          1553     1653     +100     
+ Misses         392      358      -34     
Impacted Files Coverage Δ
peepingtom/depictors/__init__.py 100.00% <ø> (ø)
peepingtom/depictors/napari/naparidepictor.py 83.33% <ø> (+14.10%) ⬆️
peepingtom/depictors/napari/particledepictor.py 85.71% <0.00%> (ø)
peepingtom/io_/read/tbl/utils.py 81.81% <50.00%> (ø)
peepingtom/gui/widgets/volume_selector.py 60.00% <60.00%> (ø)
peepingtom/peeper.py 73.52% <78.26%> (+3.17%) ⬆️
peepingtom/gui/viewer.py 96.77% <96.77%> (ø)
peepingtom/__main__.py 54.54% <100.00%> (ø)
peepingtom/_tests/test_cli.py 100.00% <100.00%> (ø)
peepingtom/depictors/depictor.py 76.47% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e7e4ee...856f255. Read the comment docs.

Copy link
Collaborator

@alisterburt alisterburt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Really excited about this - one tiny point to address then let's get this in!!

peepingtom/gui/widgets/volume_selector.py Outdated Show resolved Hide resolved
@alisterburt
Copy link
Collaborator

non-obvious fail in tests, does it happen when you test locally?

@brisvag
Copy link
Owner Author

brisvag commented Mar 16, 2021

@alisterburt I'm trying to fix it... it's a qt problem, almost certainly. Locally it's fine, but running graphical programs on the github actions VMs seems to be a bit tricky!

@alisterburt
Copy link
Collaborator

alisterburt commented Mar 16, 2021 via email

@brisvag
Copy link
Owner Author

brisvag commented Mar 17, 2021

I decided to drop testing of qt stuff, for now. It seems to be the same as this issue, which has no solution yet.
The problem actually happened locally as well, I was just doing things wrong at first. The thing is, tests pass just fine, but then the command fails with an exit code of 1 because some qt stuff breaks after all the tests are already finished.

To keep codecov happy, I added some unrelated tests for now, so we can merge this :P

@brisvag
Copy link
Owner Author

brisvag commented Mar 17, 2021

Qt tests are up and running, thanks to the make_napari_viewer pytest fixture!

@brisvag brisvag merged commit 3608ae8 into brisvag:develop Mar 17, 2021
@brisvag brisvag deleted the gui branch June 3, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants