-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Viewer code and addition of volume selector #80
Conversation
…ways, and it should be designed properly if reimplemented
Codecov Report
@@ Coverage Diff @@
## develop #80 +/- ##
===========================================
+ Coverage 79.84% 82.19% +2.35%
===========================================
Files 98 103 +5
Lines 1945 2011 +66
===========================================
+ Hits 1553 1653 +100
+ Misses 392 358 -34
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Really excited about this - one tiny point to address then let's get this in!!
non-obvious fail in tests, does it happen when you test locally? |
@alisterburt I'm trying to fix it... it's a qt problem, almost certainly. Locally it's fine, but running graphical programs on the github actions VMs seems to be a bit tricky! |
uh oh! Have you looked at the qtbot fixture?
https://pytest-qt.readthedocs.io/en/latest/intro.html
That's what's used in napari for qt testing
…On Tue, 16 Mar 2021 at 16:39, Lorenzo Gaifas ***@***.***> wrote:
@alisterburt <https://github.com/alisterburt> I'm trying to fix it...
it's a qt problem, almost certainly. Locally it's fine, but running
graphical programs on the github actions VMs seems to be a bit tricky!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#80 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABXYBYEVOWFWN7DVCQWVZC3TD6CU7ANCNFSM4ZITORHQ>
.
|
I decided to drop testing of qt stuff, for now. It seems to be the same as this issue, which has no solution yet. To keep codecov happy, I added some unrelated tests for now, so we can merge this :P |
Qt tests are up and running, thanks to the |
Volume selector is here!
Now
p.show()
will also automatically dock a simple dropdown menu widget in the napari viewer. This widget lets you select which volume to show!There's also a couple of minor bufixes thrown in.