Update Google Cloud SDK to version 404 [VS-648] #6922
Conversation
| @@ -27,17 +33,9 @@ object ActionUtils { | |||
| * | |||
| * FYI additional older versions are available on DockerHub at: | |||
| * https://hub.docker.com/r/google/cloud-sdk | |||
| * | |||
| * When updating this value, also consider updating the CromwellImagesSizeRoundedUpInGB below. | |||
There was a problem hiding this comment.
CromwellImagesSizeRoundedUpInGB wasn't being used so I deleted it instead.
| config.getOrElse("cloud-sdk-image-url", "gcr.io/google.com/cloudsdktool/cloud-sdk:354.0.0-alpine") | ||
|
|
||
| /* | ||
| * At the moment, cloud-sdk (584MB for 354.0.0-alpine) and stedolan/jq (182MB) decompressed ~= 0.8 GB |
There was a problem hiding this comment.
I think this jq reference might have been in regard to some CWL output processing code that is no longer with us. I couldn't find anything currently building an alpine + jq image so I just removed the comment.
There was a problem hiding this comment.
You also removed the cloud-sdk-image-size-gb configuration value, which we should probably keep if we're going to keep the cloud-sdk-image-url config value... except it looks like, oops, we're only using cromwellImagesSizeRoundedUpInGB and not CromwellImagesSizeRoundedUpInGB. I'm guessing that's an oversight that didn't get caught when CromwellImagesSizeRoundedUpInGB was initially introduced.
| */ | ||
| val CromwellImagesSizeRoundedUpInGB: Int = | ||
| config.getOrElse("cloud-sdk-image-size-gb", 1) | ||
| config.getOrElse("cloud-sdk-image-url", "gcr.io/google.com/cloudsdktool/cloud-sdk:404.0.0-alpine") |
There was a problem hiding this comment.
I'm planning to experiment with the slim image at the suggestion of https://partnerissuetracker.corp.google.com/issues/247814958#comment6. I'm planning to run the experiment with 354.0.0-slim and 404.0.0-alpine, and possibly 404.0.0-slim depending on the result of the other experiments.
There was a problem hiding this comment.
Interesting, good luck with that issue!
|
Superseded by #7359 |
Freshening up and syncing with pending changes in GVS.