[PROD-934] Rip out all support for PodSecurityPolicies #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snf2ye
reviewed
Mar 6, 2024
Comment on lines
46
to
47
| rbac: | ||
| # Specifies whether a psp should be created | ||
| create: false |
There was a problem hiding this comment.
Can we pull the rbac.create field too?
There was a problem hiding this comment.
We can't, per #249:
The old rbac enabled flag wrapped both both pod security policy associated resources and also tdr's permission to talk to the k8s api. This separates them so that we can disable pod security policy without breaking tdrs ability to talk to k8s.
A rename is likely in order, but I would prefer to handle that separately if so.
This was bumped too high when resolving a merge conflict.
nmalfroy
approved these changes
Mar 12, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://broadworkbench.atlassian.net/browse/PROD-934
Following successful repair of TDR Dev, Staging and Prod to disable PodSecurityPolicies for compatibility with GKE 1.25+, we'd like to fully remove PodSecurityPolicies from our Helm charts. I broke up this PR into commits for each chart.
This should be a "no-op" for those environments since we've disabled PSPs via terra-helmfile values for them, and successfully deployed / synced.
Follow-on actions: