Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DSEC-955]add rate limiting to zap #591

Merged
merged 2 commits into from
Dec 20, 2024
Merged

[DSEC-955]add rate limiting to zap #591

merged 2 commits into from
Dec 20, 2024

Conversation

sarahgibs
Copy link
Contributor

@sarahgibs sarahgibs commented Dec 20, 2024 •
edited
Loading

Added rate limiting to ZAP scanning to prevent sites like beehive from having connection errors during scanning.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sarahgibs sarahgibs changed the title add rate limiting to zap [DSEC-955]add rate limiting to zap Dec 20, 2024
@sarahgibs sarahgibs requested a review from TomConner December 20, 2024 19:09
TomConner
TomConner approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@TomConner TomConner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to rate limit all scans.

@sarahgibs sarahgibs merged commit c9d8b99 into master Dec 20, 2024
6 checks passed
@sarahgibs sarahgibs deleted the add-rate-limiting branch December 20, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomConner TomConner TomConner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarahgibs @TomConner