Refactor workflow inputs/output for consistency #668
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workflows may have different input variable names for the same inputs, or the output variable name of one workflow may not match the input variable name of its downstream workflow where the output variable is piped to the input variable. For instance, both
GatherSampleEvidence
andEvidenceQC
take a reference.fasta
as input, but the variable names are different:GatherSampleEvidence.reference_fasta
vs.EvidenceQC.genome_file
.While such inconsistencies do not have any functional impact, they can be confusing when preparing inputs to workflows (e.g., it is not clear from the variable name that
reference_fasta
andgenome_file
both expect the same input unless consulting with the configured Terra workspace or its corresponding templates), or setting up a new Terra workspace.This PR makes the following refactoring:
EvidenceQC.genome_file
as it is not used;EvidenceQC.counts
,TrainGCNV.count_files
, andMakeBincovMatrix.count_files
tocoverage_counts
to match withGatherSampleEvidence
;