Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding oncotator filtering enabled in M2 WDL. #4423

Merged
merged 3 commits into from
Mar 21, 2018

Conversation

LeeTL1220
Copy link
Contributor

Fixes #4422

@codecov-io
Copy link

codecov-io commented Feb 16, 2018

Codecov Report

Merging #4423 into master will increase coverage by 0.362%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             master     #4423       +/-   ##
==============================================
+ Coverage     79.04%   79.402%   +0.362%     
- Complexity    16447     17620     +1173     
==============================================
  Files          1047      1055        +8     
  Lines         59189     63340     +4151     
  Branches       9672     10754     +1082     
==============================================
+ Hits          46783     50293     +3510     
- Misses         8645      9125      +480     
- Partials       3761      3922      +161
Impacted Files Coverage Δ Complexity Δ
...titute/hellbender/utils/logging/OneShotLogger.java 78.571% <0%> (-21.429%) 3% <0%> (ø)
...ools/spark/sv/evidence/IntervalCoverageFinder.java 82.222% <0%> (-6.239%) 19% <0%> (+11%)
...er/tools/walkers/annotator/ReadPosRankSumTest.java 94.231% <0%> (-5.769%) 25% <0%> (+15%)
.../DiscoverVariantsFromContigAlignmentsSAMSpark.java 94.872% <0%> (-5.128%) 28% <0%> (+15%)
...ools/walkers/annotator/VariantAnnotatorEngine.java 95.161% <0%> (-2.307%) 111% <0%> (+71%)
...stitute/hellbender/utils/pileup/PileupElement.java 93.939% <0%> (-1.713%) 146% <0%> (+70%)
...dinstitute/hellbender/utils/pileup/ReadPileup.java 90.496% <0%> (-1.45%) 104% <0%> (+40%)
...s/spark/sv/discovery/AnnotatedVariantProducer.java 76.471% <0%> (-1.307%) 23% <0%> (+1%)
...lbender/tools/spark/sv/discovery/SimpleSVType.java 85.393% <0%> (-1.174%) 2% <0%> (ø)
...ecaller/AssemblyBasedCallerArgumentCollection.java 100% <0%> (ø) 1% <0%> (ø) ⬇️
... and 80 more

@LeeTL1220 LeeTL1220 requested a review from davidbenjamin March 20, 2018 15:37
@LeeTL1220
Copy link
Contributor Author

@davidbenjamin I also ran an additional test outside of our repo to make sure that this was working properly.

@LeeTL1220
Copy link
Contributor Author

LeeTL1220 commented Mar 20, 2018

@brigranger @jnktsj Note when this gets into master and gets released. To keep the previous behavior, you will want to set filter_oncotator_maf to false.

(The default is going to become true, since most cancer analysts will want it this way)

Copy link
Contributor

@davidbenjamin davidbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@davidbenjamin davidbenjamin added this to the Popularize Mutect 2 at the Broad milestone Mar 20, 2018
@LeeTL1220 LeeTL1220 merged commit 2380b73 into master Mar 21, 2018
@LeeTL1220 LeeTL1220 deleted the ll_oncotator_filter_wdl_4422 branch March 21, 2018 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants