Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use latest version of fermilite jni #4622

Merged
merged 1 commit into from
Apr 3, 2018
Merged

Conversation

tedsharpe
Copy link
Contributor

No description provided.

@mwalker174
Copy link
Contributor

It looks like there's some minor refactoring in your new graph handler. I'm not a real stickler about sneaking that in but just want to check it was intentional.

@codecov-io
Copy link

codecov-io commented Apr 2, 2018

Codecov Report

Merging #4622 into master will increase coverage by 0.005%.
The diff coverage is 70%.

@@              Coverage Diff               @@
##              master    #4622       +/-   ##
==============================================
+ Coverage     79.875%   79.88%   +0.005%     
+ Complexity     17138    17132        -6     
==============================================
  Files           1067     1067               
  Lines          62302    62292       -10     
  Branches       10108    10105        -3     
==============================================
- Hits           49764    49759        -5     
+ Misses          8600     8596        -4     
+ Partials        3938     3937        -1
Impacted Files Coverage Δ Complexity Δ
...ls/spark/sv/evidence/FermiLiteAssemblyHandler.java 85.813% <70%> (-0.14%) 79 <0> (-8)
...utils/smithwaterman/SmithWatermanIntelAligner.java 90% <0%> (+40%) 3% <0%> (+2%) ⬆️

@SHuang-Broad SHuang-Broad self-requested a review April 2, 2018 22:40
Copy link
Contributor

@SHuang-Broad SHuang-Broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tedsharpe
Copy link
Contributor Author

Thanks, Mark. Yes, intentional. We moved a couple of methods that we more naturally methods on the assembled objects rather than statics in client code at Chris' suggestion. Part of the API upgrade, from my point of view.

@tedsharpe tedsharpe force-pushed the tws_upgrade_fermilite_jni branch from d8a5250 to 8f50228 Compare April 3, 2018 12:13
Copy link
Contributor

@mwalker174 mwalker174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tedsharpe tedsharpe merged commit 78c977c into master Apr 3, 2018
@tedsharpe tedsharpe deleted the tws_upgrade_fermilite_jni branch April 3, 2018 15:33
cwhelan pushed a commit to cwhelan/gatk-linked-reads that referenced this pull request May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants