-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use latest version of fermilite jni #4622
Conversation
It looks like there's some minor refactoring in your new graph handler. I'm not a real stickler about sneaking that in but just want to check it was intentional. |
Codecov Report
@@ Coverage Diff @@
## master #4622 +/- ##
==============================================
+ Coverage 79.875% 79.88% +0.005%
+ Complexity 17138 17132 -6
==============================================
Files 1067 1067
Lines 62302 62292 -10
Branches 10108 10105 -3
==============================================
- Hits 49764 49759 -5
+ Misses 8600 8596 -4
+ Partials 3938 3937 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks, Mark. Yes, intentional. We moved a couple of methods that we more naturally methods on the assembled objects rather than statics in client code at Chris' suggestion. Part of the API upgrade, from my point of view. |
d8a5250
to
8f50228
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
No description provided.