Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of sequence dictionaries from multiple BAMs now throws warning instead of exception in CNV workflows. #4758

Merged
merged 1 commit into from
May 21, 2018

Conversation

samuelklee
Copy link
Contributor

Unfortunately, projects like TCGA with BAMs from different sequencing centers do not use the exact same sequence dictionary across them. I've relaxed validation in cases where dictionaries are checked across different BAMs so that only a warning is thrown; however, cases where dictionaries should arise from the same BAM still throw an exception.

@samuelklee samuelklee force-pushed the sl_relax_seq_dict branch from 018f760 to 1e7bf94 Compare May 10, 2018 14:04
@samuelklee samuelklee requested a review from LeeTL1220 May 10, 2018 14:04
@codecov-io
Copy link

Codecov Report

Merging #4758 into master will decrease coverage by 0.012%.
The diff coverage is 23.077%.

@@              Coverage Diff               @@
##              master    #4758       +/-   ##
==============================================
- Coverage     80.052%   80.04%   -0.012%     
  Complexity     17413    17413               
==============================================
  Files           1080     1080               
  Lines          63099    63100        +1     
  Branches       10196    10201        +5     
==============================================
- Hits           50512    50505        -7     
- Misses          8597     8599        +2     
- Partials        3990     3996        +6
Impacted Files Coverage Δ Complexity Δ
...r/arguments/CopyNumberArgumentValidationUtils.java 59.42% <0%> (-7.744%) 17 <0> (-2)
...ute/hellbender/tools/copynumber/ModelSegments.java 98.404% <33.333%> (-1.061%) 44 <0> (ø)
...ools/copynumber/DetermineGermlineContigPloidy.java 94.048% <33.333%> (-2.423%) 14 <0> (ø)
...hellbender/tools/copynumber/GermlineCNVCaller.java 84.404% <33.333%> (-1.96%) 10 <0> (ø)
...utils/smithwaterman/SmithWatermanIntelAligner.java 90% <0%> (+40%) 3% <0%> (+2%) ⬆️

@samuelklee
Copy link
Contributor Author

See #3864. Closing that issue. @LeeTL1220 can you take a look at this when you get a chance?

Copy link
Contributor

@LeeTL1220 LeeTL1220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samuelklee This looks pretty straight-forward.

@samuelklee samuelklee merged commit 6f03deb into master May 21, 2018
@samuelklee samuelklee deleted the sl_relax_seq_dict branch May 21, 2018 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants