Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SV) Add tests for AssemblyContigWithFineTunedAlignments #4961

Merged
merged 2 commits into from
Jun 28, 2018

Conversation

SHuang-Broad
Copy link
Contributor

Also fixes small bugs.

fix a bug in AssemblyContigWithFineTunedAlignments.getReasonForAlignmentClassificationFailure()

* also apprently RDD collected list is unmodifiable; forgot to make new before sorting
* close a group of sam file writers
@codecov-io
Copy link

Codecov Report

Merging #4961 into master will increase coverage by 0.034%.
The diff coverage is 75%.

@@              Coverage Diff               @@
##             master     #4961       +/-   ##
==============================================
+ Coverage     80.76%   80.795%   +0.034%     
- Complexity    17930     17947       +17     
==============================================
  Files          1094      1094               
  Lines         64523     64524        +1     
  Branches      10392     10392               
==============================================
+ Hits          52109     52132       +23     
+ Misses         8386      8370       -16     
+ Partials       4028      4022        -6
Impacted Files Coverage Δ Complexity Δ
...ignment/AssemblyContigWithFineTunedAlignments.java 91.473% <0%> (+13.953%) 58 <0> (+14) ⬆️
...iscoverFromLocalAssemblyContigAlignmentsSpark.java 73.77% <100%> (+0.217%) 2 <0> (ø) ⬇️
...utils/smithwaterman/SmithWatermanIntelAligner.java 90% <0%> (+40%) 3% <0%> (+2%) ⬆️

Copy link
Member

@cwhelan cwhelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@SHuang-Broad SHuang-Broad merged commit 54260e3 into master Jun 28, 2018
@SHuang-Broad SHuang-Broad deleted the sh-sv-test-contig-aln-signature-unknown branch June 28, 2018 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants