Exposed ability to blacklist intervals in CNV WDLs. #5027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5027 +/- ##
=========================================
Coverage 86.35% 86.35%
Complexity 28824 28824
=========================================
Files 1791 1791
Lines 133601 133601
Branches 14920 14920
=========================================
Hits 115364 115364
Misses 12834 12834
Partials 5403 5403 |
LeeTL1220
reviewed
Jul 19, 2018
| @@ -1,5 +1,6 @@ | |||
| task PreprocessIntervals { | |||
There was a problem hiding this comment.
Can you add a doc comment?
| @@ -28,6 +28,7 @@ workflow CNVSomaticPairWorkflow { | |||
| ################################## | |||
| File common_sites | |||
| File intervals | |||
| File? blacklist_intervals | |||
There was a problem hiding this comment.
Can you add a doc comment?
| @@ -23,6 +23,7 @@ workflow CNVSomaticPanelWorkflow { | |||
| #### required basic arguments #### | |||
| ################################## | |||
| File intervals | |||
samuelklee
force-pushed
the
sl_add_XL_CNV_WDLs
branch
from
4c3524e to
57e51da
Compare
|
Thanks, back to you @LeeTL1220! |
LeeTL1220
approved these changes
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively simple change, but has not been tested. The reviewer should make sure I haven't screwed it up!