Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added maxRetries to runtime in M2 WDLs #5049

Merged
merged 2 commits into from
Jul 25, 2018
Merged

Added maxRetries to runtime in M2 WDLs #5049

merged 2 commits into from
Jul 25, 2018

Conversation

davidbenjamin
Copy link
Contributor

@takutosato This is really important for overcoming transient errors in Firecloud, especially as long as we don't have call-caching for NIO.

@davidbenjamin davidbenjamin added this to the Mutect2 milestone Jul 24, 2018
@davidbenjamin davidbenjamin requested a review from takutosato July 24, 2018 16:24
@LeeTL1220
Copy link
Contributor

@davidbenjamin @takutosato Can you default to zero? Unless you can think of another use case, do we need this once we leverage the working NIO call caching?

Copy link
Contributor

@takutosato takutosato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I don't have a preference for default being 0 or 3. Up to you two @davidbenjamin @LeeTL1220

@LeeTL1220
Copy link
Contributor

If no other use case than the NIO workaround can be identified, I worry that you will do a bunch of retries on a terminal condition. Setting the default to zero would protect against that.

@codecov-io
Copy link

codecov-io commented Jul 24, 2018

Codecov Report

Merging #5049 into master will increase coverage by 0.019%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master     #5049       +/-   ##
===============================================
+ Coverage     86.359%   86.377%   +0.019%     
- Complexity     28809     28853       +44     
===============================================
  Files           1789      1791        +2     
  Lines         133512    133725      +213     
  Branches       14914     14936       +22     
===============================================
+ Hits          115299    115508      +209     
- Misses         12811     12815        +4     
  Partials        5402      5402
Impacted Files Coverage Δ Complexity Δ
...ools/copynumber/formats/records/LegacySegment.java 46.875% <0%> (ø) 7% <0%> (?)
...r/formats/collections/LegacySegmentCollection.java 72.222% <0%> (ø) 4% <0%> (?)
...ute/hellbender/tools/copynumber/ModelSegments.java 99.654% <0%> (+1.25%) 65% <0%> (+21%) ⬆️
...tools/copynumber/ModelSegmentsIntegrationTest.java 98.5% <0%> (+9.397%) 30% <0%> (+10%) ⬆️
...ithwaterman/SmithWatermanIntelAlignerUnitTest.java 90% <0%> (+30%) 2% <0%> (ø) ⬇️
...utils/smithwaterman/SmithWatermanIntelAligner.java 90% <0%> (+40%) 3% <0%> (+2%) ⬆️

@davidbenjamin davidbenjamin merged commit 7a79472 into master Jul 25, 2018
@davidbenjamin davidbenjamin deleted the db_max_retries branch July 25, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants