Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing counts for supporting alt reads in the validation normal. #5062

Merged

Conversation

LeeTL1220
Copy link
Contributor

@LeeTL1220
Copy link
Contributor Author

@davidbenjamin Testing failure is transient. Please review...

@LeeTL1220 LeeTL1220 requested a review from davidbenjamin July 27, 2018 16:29
@codecov-io
Copy link

Codecov Report

Merging #5062 into master will decrease coverage by <.001%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             master     #5062       +/-   ##
==============================================
- Coverage     86.35%   86.349%   -<.001%     
- Complexity    28824     28826        +2     
==============================================
  Files          1791      1791               
  Lines        133601    133619       +18     
  Branches      14920     14920               
==============================================
+ Hits         115364    115379       +15     
- Misses        12834     12837        +3     
  Partials       5403      5403
Impacted Files Coverage Δ Complexity Δ
...bender/utils/GATKProtectedVariantContextUtils.java 65.746% <ø> (ø) 61 <0> (ø) ⬇️
...ion/basicshortmutpileup/PowerCalculationUtils.java 96.667% <100%> (+1.429%) 18 <7> (+3) ⬆️
...tmutpileup/BasicSomaticShortMutationValidator.java 62.5% <100%> (+1.974%) 5 <0> (ø) ⬇️
...ion/basicshortmutpileup/BasicValidationResult.java 96.774% <100%> (+0.222%) 16 <2> (+1) ⬆️
...tmutpileup/ValidateBasicSomaticShortMutations.java 83.636% <100%> (+0.15%) 19 <0> (ø) ⬇️
...dateBasicSomaticShortMutationsIntegrationTest.java 100% <100%> (ø) 5 <0> (ø) ⬇️
...utils/smithwaterman/SmithWatermanIntelAligner.java 50% <0%> (-30%) 1% <0%> (-2%)
...ithwaterman/SmithWatermanIntelAlignerUnitTest.java 60% <0%> (ø) 2% <0%> (ø) ⬇️

Copy link
Contributor

@davidbenjamin davidbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Are you punting the decision as to how the normal alt count affects the validation status downstream?

@davidbenjamin davidbenjamin merged commit fdb2b65 into master Aug 2, 2018
@davidbenjamin davidbenjamin deleted the ll_5059_validation_supporting_alt_reads_in_normal branch August 2, 2018 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants