Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate some args #8140

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Deprecate some args #8140

merged 3 commits into from
Feb 28, 2023

Conversation

ldgauthier
Copy link
Contributor

Deprecate an untested VariantRecalibrator arg
Deprecate an old reblocking arg that produced invalid GVCFs
Rip out old GnarlyGenotyper code with diploid assumption
Will enable #7750

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #8140 (a102c2d) into master (0261d43) will decrease coverage by 0.006%.
The diff coverage is 100.000%.

Additional details and impacted files
@@               Coverage Diff               @@
##              master     #8140       +/-   ##
===============================================
- Coverage     86.648%   86.642%   -0.006%     
+ Complexity     38974     38957       -17     
===============================================
  Files           2337      2337               
  Lines         182791    182698       -93     
  Branches       20067     20045       -22     
===============================================
- Hits          158385    158294       -91     
- Misses         17364     17370        +6     
+ Partials        7042      7034        -8     
Impacted Files Coverage Δ
...bender/tools/walkers/variantutils/ReblockGVCF.java 80.244% <ø> (ø)
...ute/hellbender/utils/variant/GATKVCFConstants.java 80.000% <ø> (ø)
...e/hellbender/utils/variant/GATKVCFHeaderLines.java 95.337% <ø> (-0.048%) ⬇️
...tools/walkers/gnarlyGenotyper/GnarlyGenotyper.java 83.168% <100.000%> (ø)
...walkers/gnarlyGenotyper/GnarlyGenotyperEngine.java 77.647% <100.000%> (-3.906%) ⬇️
...bender/tools/walkers/vqsr/VariantRecalibrator.java 86.168% <100.000%> (ø)
...gnarlyGenotyper/GnarlyGenotyperEngineUnitTest.java 88.889% <100.000%> (-5.632%) ⬇️
...itute/hellbender/tools/LocalAssemblerUnitTest.java 92.448% <0.000%> (ø)
... and 1 more

@ldgauthier ldgauthier requested a review from droazen January 4, 2023 13:58
Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ldgauthier One comment which you are welcome to ignore

@ldgauthier ldgauthier merged commit 6b2440d into master Feb 28, 2023
@ldgauthier ldgauthier deleted the ldg_deprecate_some_args branch February 28, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants