Update base image #8228
Update base image #8228
Conversation
|
Github actions tests reported job failures from actions build 4297780099
|
lbergelson
force-pushed
the
lb_update_ubuntu
branch
from
236bff6 to
7c2f0ce
Compare
|
Github actions tests reported job failures from actions build 4419433150
|
lbergelson
force-pushed
the
lb_update_ubuntu
branch
from
cafaaf1 to
7c2f0ce
Compare
lbergelson
force-pushed
the
lb_update_ubuntu
branch
from
7c2f0ce to
a01f8b3
Compare
* Updating ubuntu to the newest 18.04 release
lbergelson
force-pushed
the
lb_update_ubuntu
branch
from
a01f8b3 to
3121f98
Compare
| @@ -1,3 +1,4 @@ | |||
| # These are files that for whatever reason we don't want to include in our distribution docker images | |||
| src/test/resources | |||
| src/test/resources/* | |||
| build/ | |||
scripts/docker/gatkbase/Dockerfile
Outdated
| software-properties-common && \ | ||
|
|
There was a problem hiding this comment.
Is this empty line not deliberate ? Does it not matter ?
There was a problem hiding this comment.
huh, that's definitely not deliberate and I would have expected it to make it break...
There was a problem hiding this comment.
It seems to make no difference.
| apt-get update -y && \ | ||
| apt-get install -y --no-install-recommends google-cloud-cli && \ | ||
| apt-get -y clean && \ | ||
| apt-get -y autoclean && \ |
There was a problem hiding this comment.
I'm so glad someone knows how todo this...
There was a problem hiding this comment.
I suspect I'm repeating myself because I don't really know how to do it. Throw all the cleaning at the wall and hope something sticks.
| @@ -6,7 +6,7 @@ FROM ubuntu:18.04 | |||
| RUN apt-get update && \ | |||
There was a problem hiding this comment.
OpenJDK 8 reference on line 1 but GitHub won't let me comment there
There was a problem hiding this comment.
@mcovarr Thank you, good catch!
I've updated the image and it seems to be working locally. Now for the true test...