Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CNNScoreVariants, CNNVariantTrain, and CNNVariantWriteTensors #9009

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

droazen
Copy link
Contributor

@droazen droazen commented Oct 18, 2024

Removed the code for these tools, now that NVScoreVariants is merged and we've moved to a Python environment that is incompatible with these legacy tools.

Also added the tools to the DeprecatedToolsRegistry.

Removed the code for these tools, now that NVScoreVariants is merged
and we've moved to a Python environment that is incompatible with these
legacy tools.

Also added the tools to the DeprecatedToolsRegistry.
@droazen
Copy link
Contributor Author

droazen commented Oct 18, 2024

@lbergelson please review

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I didn't even know we had WDL tests for this. Maybe we should resurrect them, but not in this PR.

@droazen droazen merged commit d6acb84 into master Oct 18, 2024
20 checks passed
@droazen droazen deleted the dr_remove_cnn_tools branch October 18, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants