make the API pods larger #1438
Merged
make the API pods larger #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're fairly consistently getting container restarts when pods reach their 3GB javascript heap limit. We were previously getting containers killed when they reached the pod memory limit of 4GB. We initially tried to set the JS heap limit explicitly to 3GB, because the default value wasn't causing any memory eviction before reaching the pod limits.
Now that pods are falling over because we can't allocate heap, or keep it cleaned up, @ 3GB, I think it's clear that we need more resources for these pods to service normal requests.
This doubles the memory limit for the pod to 8GBs, and sets the request to 7GBs. The heap is being set to 6GBs, which uses most of the available memory, and leaves a bit more for OS-related overhead in the container.