Don't not add a period to output basenames #1430
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A change was introduced last year to
CheckFingerprint
which made it only add a period to the end of theOUTPUT
argument if it did not already end with a period. This causes errors in our pipeline when sample aliases end in a period, because we derive our cromwell outputs based on the sample alias concatenated with "fingerprinting_summary_metrics" and "fingerprinting_detail_metrics". If sample_alias isMyCoolSampleG.T.
, the output files should beMyCoolSampleG.T..fingerprinting_summary_metrics
andMyCoolSampleG.T..fingerprinting_detail_metrics
Checklist (never delete this)
Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.
Content
Review
For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests