Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Floats from GtcToVcf in VcfToAdpc #1436

Merged
merged 3 commits into from
Dec 9, 2019
Merged

Conversation

tlangs
Copy link
Contributor

@tlangs tlangs commented Dec 3, 2019

Description

If GtcToVcf spit out a VCF with InfiniumVcfFields.NORMX or InfiniumVcfFields.NORMY over 1,000, it VcfToAdpc would fail because the written-out float had a comma separating the hundreds and thousands place. Using the same DecimalFormat in VcfToAdpc fixes the issue.


Checklist (never delete this)

Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.

Content

  • Added or modified tests to cover changes and any new functionality
  • Edited the README / documentation (if applicable)
  • All tests passing on Travis

Review

  • Final thumbs-up from reviewer
  • Rebase, squash and reword as applicable

For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests

Copy link
Contributor

@gbggrant gbggrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this (handling NORMX or NORMY > 1000)? Probably should just need to add an offending line to Test.gtc.records.csv.

@tlangs tlangs merged commit a3021a7 into master Dec 9, 2019
@tlangs tlangs deleted the tl_PO-21836_vcf_to_adpc_fix branch December 9, 2019 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants