Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NP-remove_r_from_argument #1508

Merged
merged 3 commits into from
May 14, 2020
Merged

NP-remove_r_from_argument #1508

merged 3 commits into from
May 14, 2020

Conversation

nikellepetrillo
Copy link
Contributor

Description

Give your PR a concise yet descriptive title

Removed the "r" from rbuildPrerequisitesMessage because we assumed it was a typo.

Explain the motivation for making this change. What existing problem does the pull request solve?
Mention any issues fixed, addressed or otherwise related to this pull request, including issue numbers or hard links for issues in other repos.
You can delete these instructions once you have written your PR description.


Checklist (never delete this)

Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.

Content

  • Added or modified tests to cover changes and any new functionality
  • Edited the README / documentation (if applicable)
  • All tests passing on Travis

Review

  • Final thumbs-up from reviewer
  • Rebase, squash and reword as applicable

For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Looks like a typo to me. What's with the unrelated test file deletions? Could they be taken out of this pr?

@nikellepetrillo
Copy link
Contributor Author

Files were accidentally deleted, but they have been restored now

@nikellepetrillo nikellepetrillo merged commit 40b8d40 into master May 14, 2020
@nikellepetrillo nikellepetrillo deleted the NP-remove-r-from-arg branch May 14, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants