GL-670 Generate BPM.CSV from BPM file #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
jessicaway
reviewed
May 27, 2020
src/main/java/picard/arrays/illumina/BpmToNormalizationManifestCsv.java
Outdated
Show resolved
Hide resolved
jessicaway
requested changes
May 27, 2020
src/main/java/picard/arrays/illumina/BpmToNormalizationManifestCsv.java
Outdated
Show resolved
Hide resolved
src/main/java/picard/arrays/illumina/BpmToNormalizationManifestCsv.java
Outdated
Show resolved
Hide resolved
jessicaway
added
the
Waiting For Revisions
|
@jessicaway @pshapiro4broad I think I've addressed all of your comments. Can you please take another look? |
gbggrant
removed
the
Waiting For Revisions
jessicaway
approved these changes
Jun 2, 2020
| * A simple class to represent a locus entry in an Illumina Bead Pool Manifest (BPM) file | ||
| */ | ||
| public class IlluminaBPMLocusEntry { | ||
| String ilmnId; // IlmnID (probe identifier) of locus |
There was a problem hiding this comment.
generally prefer comments on separate lines
There was a problem hiding this comment.
Thanks. Forgot to get them all
Have CompareGtcFiles use IlluminaBPMFile Pass the actual bpm file to the IlluminaBPMFile constructor - no longer pass in DataInputStream.
gbggrant
force-pushed
the
gg_GL-670_BpmToBpmDotCsv
branch
from
f1ec492 to
16c5e8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality to parse Illumina BPM (Bead Pool Manifest) files
Added new CLP to generate Illumina 'normalization manifest' CSV file'
Modified GtcToVcf and CompareGtcFiles to use IlluminaBPMFile parser (rather than using the old csv)
Description
Give your PR a concise yet descriptive title
Please explain the changes you made here.
Explain the motivation for making this change. What existing problem does the pull request solve?
Mention any issues fixed, addressed or otherwise related to this pull request, including issue numbers or hard links for issues in other repos.
You can delete these instructions once you have written your PR description.
Checklist (never delete this)
Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.
Content
Review
For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests