Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete references to Google Genomics API #1858

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Remove obsolete references to Google Genomics API #1858

merged 1 commit into from
Feb 9, 2023

Conversation

lbergelson
Copy link
Member

  • The Google Genomics API was turned off years ago. This removes a global argument (GA4GH_CLIENT_SECRETS) which was used with it and several initialization steps in CommandLineProgram which are no longer meaningful.

@lbergelson
Remove obsolete references to Google Genomics API
47f1b1b 
* The Google Genomics API was turned off years ago. This removes a global
argument (GA4GH_CLIENT_SECRETS) which was used with it and several initialization
steps in CommandLineProgram which are no longer meaningful.
droazen
droazen approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@droazen droazen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lbergelson lbergelson merged commit 7ff09b8 into master Feb 9, 2023
@lbergelson lbergelson deleted the lb_remove_google_genomics_init branch February 9, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droazen droazen droazen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lbergelson @droazen