Add tests to verify sequence dictionary MD5s respect dos line endings. #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
lbergelson
approved these changes
Jun 2, 2023
There was a problem hiding this comment.
@cmnbroad This seems convincing to me. Thanks for investigating.
| // Test that dictionary MD5s are invariant across dos/unix line endings | ||
| @Test | ||
| public void testSequenceMD5sRespectLineEndings() throws IOException { | ||
| // NOTE: the .fasta test files here that use windows cr/lf line endings have to be listed in |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to verify the issue reported in #1814. But, neither I nor Chris K. can reproduce the issue - it looks like we correctly respect dos line endings, and are concordant with samtools either way. Since I've already done the work, we might well add these tests.