Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all our dependencies to the latest version #1901

Merged
merged 4 commits into from
Jul 28, 2023

Conversation

lbergelson
Copy link
Member

No description provided.

@lbergelson lbergelson force-pushed the lb_update_dependenies branch from bdb1826 to f7ce0d7 Compare July 20, 2023 16:32
build.gradle Outdated
implementation 'org.apache.commons:commons-lang3:3.12.0'
implementation 'com.google.cloud:google-cloud-nio:0.126.9'
implementation 'commons-io:commons-io:2.11.0'
implementation 'org.broadinstitute:gatk-native-bindings:1.0.0'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding an explicit dependency here is is necessary because of a some combination of gradle upgrades/changes to the way that gkl publishes it's dependencies. See IntelLabs/GKL#197

@lbergelson lbergelson marked this pull request as ready for review July 20, 2023 16:35
@lbergelson lbergelson requested a review from droazen July 20, 2023 16:35
@lbergelson
Copy link
Member Author

@droazen This should be complementary to your GATK upgrade branch.

Copy link
Contributor

@kshakir kshakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kshakir kshakir merged commit 9470afb into master Jul 28, 2023
@kshakir kshakir deleted the lb_update_dependenies branch July 28, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants