Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll pages at bottom #982

Merged
merged 3 commits into from
Aug 5, 2019
Merged

scroll pages at bottom #982

merged 3 commits into from
Aug 5, 2019

Conversation

lizzij
Copy link
Contributor

@lizzij lizzij commented Aug 1, 2019

In variant search page:

  • add a scroll to top button
  • display pagination field when > 1 pages

Copy link
Collaborator

@hanars hanars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you change the form name, this is good to get merged!

<Grid.Column width={11} floated="right" textAlign="right">
<ReduxFormWrapper
onSubmit={onSubmit}
form="editSearchedVariantsDisplay"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should never have two forms with the same form prop, you should name this something different to differentiate it from the other one

@lizzij lizzij merged commit 4c0f5e6 into dev Aug 5, 2019
@lizzij lizzij deleted the scroll-pages-at-bottom branch August 7, 2019 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants