GH-820: Strictly lint helm files

.github/workflows/pr-helm-lint.yml

@@ -0,0 +1,54 @@
+# This workflow triggers helm linting on PRs and master branch pushes
+# that affect helm files
+name: Helm Chart Linting on Pull Requests and Master
+
+on:
+  push:
+    branches:
+      - master
+    paths:
+      - helm/wfl/**
+  pull_request:
+    paths:
+      - helm/wfl/**
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    container:
+      image: quay.io/helmpack/chart-testing:v3.0.0-rc.1
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+        # `ct lint` likes to find charts on its own using git
+        # history.
+      - name: Fetch History
+        run: git fetch --prune --unshallow
+
+        # We keep this around because it does version bump and
+        # maintenance checks outside of what `helm lint` does.
+        # It is separate because this needs to be at the top of
+        # the repo, and it is cleaner to use the
+        # working-directory directive below.
+      - name: Chart Test Basic Lint
+        run: ct lint --config ct.yaml
+
+        # These are each actually run by `ct lint`, but we want
+        # to see their output and set arguments ourselves
+        # (--strict). Because this GitHub Action is infrequently
+        # run, duplicating the checks for the sake of keeping
+        # this Action simple is worth it.
+      - name: Helm Chart Strict Lint
+        working-directory: ./helm/wfl
+        run: |
+          helm lint --strict --namespace default
+          yamale --schema /etc/ct/chart_schema.yaml Chart.yaml
+          yamllint --config-file /etc/ct/lintconf.yaml --strict Chart.yaml values.yaml
+
+      # We could theoretically run `ct install` or
+      # something else here, but there were breadcrumbs
+      # in previous Helm lint actions that installing
+      # fails on hyphenated names, so more work would
+      # need to be done to eliminate hyphens from
+      # generated names

helm/wfl/Chart.yaml

@@ -4,10 +4,10 @@ description: A Helm chart for deploy WorkFlow Launcher on Kubernetes
 
 type: application
 
-version: 0.2.6
+version: 0.2.7
 
 home: https://github.com/broadinstitute/wfl
-appVersion: 0.2.6
+appVersion: 0.2.7
 keywords:
 - clojure
 - cloud

helm/wfl/values.yaml

@@ -1,6 +1,9 @@
 # Default values for wfl.
 # This is a YAML-formatted file.
 # Declare variables to be passed into your templates.
+fullnameOverride: ""
+nameOverride: ""
+
 replicaCount: 1
 revisionHistoryLimit: 1
 
@@ -103,6 +106,7 @@ rbac:
 serviceAccount:
   # Specifies whether a service account should be created
   create: false
+  name: ""
 
 podSecurityContext: {}
   # fsGroup: 2000