Handle case where there's a cached dependencies object, but no dependencies. #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to add a test for the bug you ran into? Would make the failure case easier to understand and help ensure we don't regress... |
chriseppstein
force-pushed
the
degenerate-dependencies
branch
from
439a28e to
e2f679d
Compare
|
@rwjblue I've added a test case. |
…t no dependencies.
chriseppstein
force-pushed
the
degenerate-dependencies
branch
from
e2f679d to
9fb0865
Compare
rwjblue
reviewed
Aug 28, 2020
Comment on lines
+1447
to
+1448
| rimraf(subject.processor.processor._cache.root); | ||
| rimraf(subject.processor.processor._syncCache.root); |
There was a problem hiding this comment.
This is just ensuring that we aren't accidentally using a prior cache right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subtle bug that has a work-around (add a file that's a dependency, clear the cache) but it really messes up the "Getting Started" experience when working with a new addon that uses dependencies.