Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue fs-extra migration #1

Closed
wants to merge 7 commits into from
Closed

Continue fs-extra migration #1

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
28457fd
fs-extra usage
May 29, 2018
c11756a
spec migrate from shelljs to fs-extra
May 29, 2018
c4bcf7b
Get rid of shelljs usage in helpers.js
raphinesse May 29, 2018
0b64582
Get rid of shelljs
raphinesse May 29, 2018
b07c608
Cleanup
raphinesse May 29, 2018
eec80ce
Fix two incorrect fs.copySync transformations
raphinesse May 29, 2018
bda596a
Cleanup tmpDir handling in spec
raphinesse May 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions spec/create.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,9 @@ var project = path.join(tmpDir, appName);

// Setup and teardown test dirs
beforeEach(function () {
fs.removeSync(project);
fs.ensureDirSync(tmpDir);
fs.emptyDirSync(tmpDir);
});
afterEach(function () {
afterAll(function () {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change and why here?

Copy link
Author

@raphinesse raphinesse May 29, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why: Since with emptyDirSync we empty tmpDir in beforeEach so there's no need to delete the tmpDir itself after every test, only at the very end.

Why here: Because this change is kind of enabled by the rich fs-extra API 🤷‍♂️

process.chdir(path.join(__dirname, '..')); // Needed to rm the dir on Windows.
fs.removeSync(tmpDir);
});
Expand Down