Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajoute le support du fichier RecetteÀMarcel en bon français #23

Merged
merged 2 commits into from
Jan 23, 2016

Conversation

thomas-maurice
Copy link
Collaborator

Cette requête de tirage ajoute la possibilité non seulement de détecter un fichier RecetteÀMarcel dans le répertoire courant, mais de le traduire de son bon format vers un Dockerfile.

@AdrieanKhisbe
Copy link

👍 :trollface:

@@ -57,7 +91,9 @@ def check_for_marcefile(command):
if exists(join(dirname(__file__), u'RecetteÀMarcel')):
# Check if a "-f" argument was not already given
if '-f' not in command:
command = command[:2] + ['-f', u'./RecetteÀMarcel'] + command[2:]
# We want to generate a file with the propre Dockerfile format
translate_marcefile(u'RecetteÀMarcel', u'.RecetteÀMarcel.Dockerfile')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translated_marcelfile

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are talking about the function name ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed !

@AdrieanKhisbe
Copy link

Ces noms de variables sont un peu trop anglophones :trollface:
NonMaisOh ^^

@thomas-maurice
Copy link
Collaborator Author

If everyone is okay I can merge this !

@brouberol
Copy link
Owner

👍

thomas-maurice added a commit that referenced this pull request Jan 23, 2016
Ajoute le support du fichier RecetteÀMarcel en bon français
@thomas-maurice thomas-maurice merged commit e5cbc0a into brouberol:master Jan 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants