Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat boxes as owned pointers #154

Merged
merged 19 commits into from
Jun 9, 2024
Merged

Treat boxes as owned pointers #154

merged 19 commits into from
Jun 9, 2024

Conversation

JustusAdam
Copy link
Collaborator

@JustusAdam JustusAdam commented May 31, 2024

What Changed?

Pointers of type Box are no longer associated with UNKNOWN_REGION and thus not considered to be aliasing one another.

Also gets rid of ModelControl arguments, since they are unused.

Why Does It Need To?

Fixes the overtaint associated with the aliasing behavior of box.

Checklist

  • Make tcx an argument to is_direct
  • Above description has been filled out so that upon quash merge we have a
    good record of what changed.
  • New functions, methods, types are documented. Old documentation is updated
    if necessary
  • Documentation in Notion has been updated
  • Tests for new behaviors are provided
    • New test suites (if any) ave been added to the CI tests (in
      .github/workflows/rust.yml) either as compiler test or integration test.
      Or justification for their omission from CI has been provided in this PR
      description.

@JustusAdam JustusAdam self-assigned this May 31, 2024
@JustusAdam JustusAdam requested a review from willcrichton June 5, 2024 00:48
@JustusAdam
Copy link
Collaborator Author

@willcrichton this is the changes I made to accommodate boxes. Sadly most of them aren't visible here, because they're in rustc_utils. But maybe you could take a look at the test cases in boxes.rs and see if you have any further ideas for things to check for.

@JustusAdam JustusAdam merged commit c870cef into main Jun 9, 2024
4 checks passed
@JustusAdam JustusAdam deleted the box-precision branch November 21, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant