Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update resolve dependency #97

Merged
merged 3 commits into from
Aug 3, 2020
Merged

Update resolve dependency #97

merged 3 commits into from
Aug 3, 2020

Conversation

goto-bus-stop
Copy link
Member

@goto-bus-stop goto-bus-stop commented Jun 18, 2020 •
edited
Loading

Closes #85, closes #88, closes #93

This updates resolve and updates the tests to account for a resolve bugfix.

The implementation parts of #92 are removed in favour of using resolve's preserveSymlinks option.

This still causes a test failure in browserify (#93 (comment)). It would also be good to check if the tests of some other major dependents still pass with these changes.

@goto-bus-stop goto-bus-stop mentioned this pull request Jun 18, 2020
Closed
@goto-bus-stop goto-bus-stop marked this pull request as ready for review August 3, 2020 07:11
@goto-bus-stop
Update resolve to 1.17
cb26bd2
@goto-bus-stop
Fix tests
ed75d00 
Removes `package: { main: 'fixtures' }` from test cases where it was
copy-pasted from earlier tests.

Updates expected results since the bugfix in `resolve`.
@goto-bus-stop
Revert #92, use resolve's preserveSymlinks option
03d3067
@goto-bus-stop goto-bus-stop merged commit 3933dae into master Aug 3, 2020
@goto-bus-stop goto-bus-stop deleted the resolve-twelve branch August 3, 2020 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update resolve dependency to 1.12.0
1 participant
@goto-bus-stop