Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] update dependencies #13

Closed
wants to merge 1 commit into from
Closed

[WIP] update dependencies #13

wants to merge 1 commit into from

Conversation

fanatid
Copy link

@fanatid fanatid commented Apr 15, 2016

Depends: browserify/ripemd160#14 browserify/sha.js#36
Ref: #11 #12

@fanatid fanatid force-pushed the feature/update-hashes branch from ad209b2 to 58e06c1 Compare April 15, 2016 10:31
case 'RMD160':
return new RIPEMD160()
case 'RIPEMD160':
return new RIPEMD160()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could just be a fall-through, maybe prefer the RIPEMD160 branch first

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right, updated

@dcousens
Copy link
Member

utACK 58e06c1, obviously blocked on sha.js updating etc

md5.js extracted to crypto-browserify/md5.js
ripemd160 updated for supporting streams in own repository
sha.js updated for using hash-base instead cipher-base
@fanatid fanatid force-pushed the feature/update-hashes branch from 58e06c1 to 69c84c5 Compare April 18, 2016 05:31
@dcousens
Copy link
Member

is this still current?

@fanatid
Copy link
Author

fanatid commented Apr 20, 2017

sha.js still not uses hash-base, so still WIP

@dcousens
Copy link
Member

Close in favour of #19

@dcousens dcousens closed this May 24, 2017
@fanatid fanatid deleted the feature/update-hashes branch May 24, 2017 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants