[New] include filename in error message #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Jun 15, 2018
ljharb
force-pushed
the
master
branch
4 times, most recently
from
c571196 to
57b5bec
Compare
ljharb
added a commit
that referenced
this pull request
Jun 15, 2018
[New] include filename in error message
ljharb
added a commit
that referenced
this pull request
Jun 15, 2018
ljharb
added a commit
that referenced
this pull request
Jun 15, 2018
v1.8.0 - [New] include filename in error message (#162) - [New] core: add `trace_events`, `v8/tools/arguments` - [New] add fs/promises to the list of core modules - [Fix] core: `_tls_legacy` is removed in node 10 - [Tests] up to `node` `v10.1`, `v9.11`, `v8.11`, `v6.14`, `4.9`
|
Released in v1.8.0 |
goto-bus-stop
added a commit
that referenced
this pull request
Jun 17, 2018
PR #162 introduced a `parent` variable that contains either the full filename of the requiring module or the `basedir`. Some of the places where `basedir` was used were updated to use `parent` instead, but that's not correct; the `path.resolve()` calls would receive the full filename instead of the directory name. This patch reverts the improper `parent` uses to `basedir`.
ljharb
pushed a commit
that referenced
this pull request
Jun 17, 2018
PR #162 introduced a `parent` variable that contains either the full filename of the requiring module or the `basedir`. Some of the places where `basedir` was used were updated to use `parent` instead, but that's not correct; the `path.resolve()` calls would receive the full filename instead of the directory name. This patch reverts the improper `parent` uses to `basedir`.
This was referenced Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates changes submitted by @jmm to fix Issue #60, resolves test errors. Was originally PR #64.
Fixes #60. Closes #64. Replaces #161.