Fixup: add missing call operator in template #299
Conversation
The `super` keyword used in a statement in the HTML footer template was missing parentheses to perform a method call; this caused the template rendering to emit a Python string describing the parent template object, instead of rendering the parent template as intended.
|
Ah good, the CI is still happy. Please add a CHANGELOG entry for this, using the format already present in the file. Create a new No tests needed. Thanks! |
|
The CI failure here was in the final docs linkcheck job, because for some reason Stack Overflow was complaining about too many requests to a particular Q&A post. Proceeding to merge despite the failing CI, because the only failure is a trivial/transient problem. Thanks for the fix, @jayaddison! |
|
You're welcome - thanks @bskinn! |
|
Hi @bskinn - do you have any plans to release an updated version with this fixup in place? The reason I ask is that I think it should fix some documentation build reproducibility issues for the |
|
Ah - I had planned to merge this once #296 was finished, but then we decided not to merge and I'd forgotten this needed to go in. I need to make a maintenance release anyways, with 3.13 now out of rc, so - yes, I'll get a new version cut soon. So, yeah, thanks for the nudge and the tracker link, @jayaddison -- I hadn't appreciated that this would be fixing a specific problem out there! |
|
No problem - thank you! |
Is the PR a fix or a feature?
Fix
Describe the changes in the PR
The
superkeyword used in a statement in the HTML footer template was missing parentheses to perform a method call; this caused the template rendering to emit a Python string describing the parent template object, instead of rendering the parent template as intended.Does this PR close any issues?
Closes #298.
Does the PR change/update the following, if relevant?