Name downloaded playlists by Content-Disposition #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y the server for downloaded files
luludotdev
approved these changes
Nov 25, 2021
KibbeWater
added a commit
to KibbeWater/ModAssistant
that referenced
this pull request
Dec 9, 2021
Support Content-Disposition header for download filenames (bsmg#419)
kcrg
pushed a commit
to kcrg/ModAssistant
that referenced
this pull request
Feb 23, 2022
Add parameter to allow downloads to prefer to use the name provided by the server for downloaded files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When downloading playlists (and previously zips) from beatsaver the last url segment is not always the best name for the downloaded file. BeatSaver provides a header with both of these that suggests a name for the downloaded file. In the case of maps this is "{map key} ({song name} - {artist name}).zip" and for playlists it is "BeatSaver - {playlist name}.bplist"
This PR will prefer the server's suggestion for playlists which should result in the top file being created:
This is not intended to alter anything but the naming