Core Lightning: Add support for custom TLV records #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisreimann
commented
Dec 10, 2022
| var tlvData = new Dictionary<ulong,string> | ||
| var val696969 = Encoding.Default.GetBytes("123456"); | ||
| var val112111100 = Encoding.Default.GetBytes("wal_hrDHs0RBEM576"); | ||
| var tlvData = new Dictionary<ulong, byte[]> |
There was a problem hiding this comment.
Pass in the values as byte[] and also get them back as byte[], so that we can support it across implementations.
Comment on lines
-383
to
-387
| var amount = LightMoney.Satoshis(21); | ||
| var preimage = new byte[32]; | ||
| new Random().NextBytes(preimage); | ||
| var paymentHash = new uint256(Hashes.SHA256(preimage)); |
There was a problem hiding this comment.
This is only required for LND, moved it to the LND PayAsync method. The other implementations don't even allow to defined a payment hash for keysend payments.
| @@ -8,6 +8,7 @@ namespace BTCPayServer.Lightning | |||
| public interface ILightningClient | |||
| { | |||
| Task<LightningInvoice> GetInvoice(string invoiceId, CancellationToken cancellation = default); | |||
| Task<LightningInvoice> GetInvoice(uint256 paymentHash, CancellationToken cancellation = default); | |||
There was a problem hiding this comment.
Added this to be able to test the invoice that was generated by a keysend payemnt.
src/BTCPayServer.Lightning.Eclair/Models/GetSentInfoResponse.cs
Outdated
Show resolved
Hide resolved
dennisreimann
force-pushed
the
keysend-refactoring
branch
from
f5b7130 to
d9efec3
Compare
dennisreimann
added a commit
to dennisreimann/BTCPayServer.Lightning
that referenced
this pull request
Dec 14, 2022
Extracted these from btcpayserver#111: - Incorporate payment timeout pattern from btcpayserver#106 - Improve failure response - Fix missing payment info (some [`getsentinfo` properties](https://acinq.github.io/eclair/#getsentinfo) weren't correct) - Upgrade containers to 0.8.0
Merged
NicolasDorier
pushed a commit
that referenced
this pull request
Dec 15, 2022
Extracted these from #111: - Incorporate payment timeout pattern from #106 - Improve failure response - Fix missing payment info (some [`getsentinfo` properties](https://acinq.github.io/eclair/#getsentinfo) weren't correct) - Upgrade containers to 0.8.0
dennisreimann
force-pushed
the
keysend-refactoring
branch
from
d9efec3 to
e4f0d24
Compare
NicolasDorier
force-pushed
the
master
branch
from
1d37a9c to
edb9ce3
Compare
dennisreimann
force-pushed
the
keysend-refactoring
branch
from
e4f0d24 to
1c70fe4
Compare
Merged
dennisreimann
force-pushed
the
keysend-refactoring
branch
2 times, most recently
from
3648402 to
67c6d97
Compare
dennisreimann
changed the title
dennisreimann
force-pushed
the
keysend-refactoring
branch
from
0c2ff22 to
fa47c90
Compare
dennisreimann
force-pushed
the
keysend-refactoring
branch
from
fa47c90 to
0171a5a
Compare
dennisreimann
force-pushed
the
keysend-refactoring
branch
from
0171a5a to
931a167
Compare
dennisreimann
force-pushed
the
keysend-refactoring
branch
from
931a167 to
64ada8b
Compare
- Add GetInvoice by payment hash - PayResponse: Add payment hash, preimage and status to payment details - Core Lightning: Add support for custom TLV records
dennisreimann
force-pushed
the
keysend-refactoring
branch
from
64ada8b to
e59859c
Compare
|
Didn't receive any feedbackl for my questions on the CLN issue. Closing this because Core Lightning doesn't seem to wanna support this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for input for this comment to continue. Looks like it's not doable with CLN 22.11