Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove table of content script #127

Merged
merged 5 commits into from
May 8, 2023
Merged

Remove table of content script #127

merged 5 commits into from
May 8, 2023

Conversation

buildbreaker
Copy link
Contributor

@buildbreaker buildbreaker commented Apr 25, 2023 •
edited
Loading

😢

@andrewparmet
Copy link
Collaborator

Various invisible elements should be removed from the readme: https://github.com/bufbuild/buf-gradle-plugin/blob/main/README.md?plain=1#L29-L33 and https://github.com/bufbuild/buf-gradle-plugin/blob/main/README.md?plain=1#L12.

Is this going to be replaced with something? Or is it all manual from here?

@buildbreaker
Copy link
Contributor Author

Good question. My original intention was to do it manually but we might end up just axing it on another README.md pass

@buildbreaker buildbreaker requested a review from rebello95 May 8, 2023 18:23
@buildbreaker buildbreaker merged commit 2e208e3 into main May 8, 2023
@buildbreaker buildbreaker deleted the achiu/remove-table-of-content-script branch May 8, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebello95 rebello95 rebello95 approved these changes

@andrewparmet andrewparmet Awaiting requested review from andrewparmet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@buildbreaker @andrewparmet @rebello95